dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/37777?usp=email )
Change subject: mgcp_network: add missing ntohs ......................................................................
mgcp_network: add missing ntohs
We must use ntohs before passing the RTCP port to osmo_sockaddr_port
Related: OS#6527 Change-Id: I9773c7b1fda8c9b429723ef9f0db0b58894b28fe --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/77/37777/1
diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index 58d85df..fd27e9a 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -1251,7 +1251,7 @@ return 0; } else if (!trunk->omit_rtcp) { struct osmo_sockaddr rtcp_addr = rtp_end->addr; - osmo_sockaddr_set_port(&rtcp_addr.u.sa, rtp_end->rtcp_port); + osmo_sockaddr_set_port(&rtcp_addr.u.sa, ntohs(rtp_end->rtcp_port)); LOGPENDP(endp, DRTP, LOGL_DEBUG, "send to %s %s rtp_port:%u rtcp_port:%u\n", dest_name, osmo_sockaddr_ntop(&rtcp_addr.u.sa, ipbuf),