Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email ) Change subject: vlr: add PS support ...................................................................... Patch Set 5: (6 comments) File src/libvlr/vlr.c: https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/dd481082_2020fc34?usp… : PS5, Line 1490: return osmo_fsm_inst_dispatch(vsub->lu_fsm, can go in same line. File src/libvlr/vlr_lu_fsm.c: https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/675a8d9f_ae91bfc1?usp… : PS5, Line 357: int N; /*! counter of timeouts */ can we have something more descriptive like num_timeouts? https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/64685247_5751bfae?usp… : PS5, Line 569: static void vlr_lu_compl_fsm_reset_n(struct osmo_fsm_inst *fi, uint32_t prev_state) I'd really prefer have proper function names, one for each state with its name plus "oenenter" appended to it. Makes it a lot easier following the FSM. https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/8fc48866_adbec831?usp… : PS5, Line 1437: static void lu_fsm_reset_n(struct osmo_fsm_inst *fi, uint32_t prev_state) same, state name + "oneneter" https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/4eae01f4_6e32efd7?usp… : PS5, Line 1589: lfp->vlr->ops.tx_lu_rej(lfp->msc_conn_ref, gsm48_cause, lfp->lu_type); need to guard for null ptr func? https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/c9542e16_a04e3050?usp… : PS5, Line 1607: vlr->ops.tx_id_req(lfp->msc_conn_ref, GSM_MI_TYPE_IMSI); need to guard for null ptr func? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0 Gerrit-Change-Number: 38490 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 14 Jan 2025 15:56:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No