Attention is currently required from: laforge, lynxis lazus.

View Change

6 comments:

• File src/libvlr/vlr.c:

  • Patch Set #5, Line 1490: return osmo_fsm_inst_dispatch(vsub->lu_fsm,

    can go in same line.

• File src/libvlr/vlr_lu_fsm.c:

  • Patch Set #5, Line 357: int N; /*! counter of timeouts */

    can we have something more descriptive like num_timeouts?

  • Patch Set #5, Line 569: static void vlr_lu_compl_fsm_reset_n(struct osmo_fsm_inst *fi, uint32_t prev_state)

    I'd really prefer have proper function names, one for each state with its name plus "oenenter" appended to it. Makes it a lot easier following the FSM.

  • Patch Set #5, Line 1437: static void lu_fsm_reset_n(struct osmo_fsm_inst *fi, uint32_t prev_state)

    same, state name + "oneneter"

  • Patch Set #5, Line 1589: lfp->vlr->ops.tx_lu_rej(lfp->msc_conn_ref, gsm48_cause, lfp->lu_type);

    need to guard for null ptr func?

  • Patch Set #5, Line 1607: vlr->ops.tx_id_req(lfp->msc_conn_ref, GSM_MI_TYPE_IMSI);

    need to guard for null ptr func?

To view, visit change 38490. To unsubscribe, or for help writing mail filters, visit settings.