Attention is currently required from: lynxis lazus.

fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666?usp=email )

Change subject: GSUP Templates: fix empty destination_name in GSUP ISD/UL ......................................................................

Patch Set 2: Code-Review-1

(4 comments)

File library/GSUP_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666/comment/d1f6a494_e4401... : PS2, Line 421: omit This change makes no sense to me, since `ts_GSUP_UL_RES` cannot yield `omit`. It's always a value.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666/comment/54e7c42c_6aba1... : PS2, Line 437: omit This change makes no sense to me, since `ts_GSUP_UL_RES` cannot yield `omit`. It's always a value.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666/comment/3a50ba04_79283... : PS2, Line 447: omit likewise, it should be `(value)`

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666/comment/4a5928f6_c6adb... : PS2, Line 448: template (omit) octetstring source_name := omit, : please fix alignment here