Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38569?usp=email )
Change subject: ranap: Add API to encode Reset Resource into msgb ......................................................................
Patch Set 1:
(2 comments)
File include/osmocom/ranap/ranap_msg_factory.h:
https://gerrit.osmocom.org/c/osmo-iuh/+/38569/comment/e009aa75_75648c0d?usp=... : PS1, Line 71: int is_ps Change it to `bool` before Pau notices this! Oh, it's Pau's patch ;) </SCNR>
(Personally I am absolutely fine with using `int` for boolean logic. Especially since using an `int` here is consistent with the existing API. But I remember getting review comments like "no! new code shall be using boool!")
File src/ranap_msg_factory.c:
https://gerrit.osmocom.org/c/osmo-iuh/+/38569/comment/569efbf6_d3960cd5?usp=... : PS1, Line 1027: release request same problem here
-
fixeria