laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30017 )
Change subject: layer23: fix -Werror=old-style-definition problems ......................................................................
layer23: fix -Werror=old-style-definition problems
Change-Id: I0187acb02de6fd22ccc86c112640caa8aa3fa2bc --- M src/host/layer23/src/common/main.c M src/host/layer23/src/misc/app_bcch_scan.c M src/host/layer23/src/misc/app_cbch_sniff.c M src/host/layer23/src/misc/app_ccch_scan.c M src/host/layer23/src/misc/app_cell_log.c M src/host/layer23/src/misc/app_echo_test.c M src/host/layer23/src/mobile/main.c 7 files changed, 10 insertions(+), 10 deletions(-)
Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve laforge: Looks good to me, approved
diff --git a/src/host/layer23/src/common/main.c b/src/host/layer23/src/common/main.c index 6781bae..f3d1ad1 100644 --- a/src/host/layer23/src/common/main.c +++ b/src/host/layer23/src/common/main.c @@ -73,7 +73,7 @@ printf("Usage: %s\n", app); }
-static void print_help() +static void print_help(void) { int options = 0xff; struct l23_app_info *app = l23_app_info(); @@ -212,7 +212,7 @@ exit (0); }
-static void print_copyright() +static void print_copyright(void) { struct l23_app_info *app; app = l23_app_info(); diff --git a/src/host/layer23/src/misc/app_bcch_scan.c b/src/host/layer23/src/misc/app_bcch_scan.c index c0c158b..257469c 100644 --- a/src/host/layer23/src/misc/app_bcch_scan.c +++ b/src/host/layer23/src/misc/app_bcch_scan.c @@ -60,7 +60,7 @@ .contribution = "Contributions by Holger Hans Peter Freyther\n", };
-struct l23_app_info *l23_app_info() +struct l23_app_info *l23_app_info(void) { return &info; } diff --git a/src/host/layer23/src/misc/app_cbch_sniff.c b/src/host/layer23/src/misc/app_cbch_sniff.c index e011a4d..33b1dfa 100644 --- a/src/host/layer23/src/misc/app_cbch_sniff.c +++ b/src/host/layer23/src/misc/app_cbch_sniff.c @@ -203,7 +203,7 @@ .contribution = "Contributions by Holger Hans Peter Freyther\n", };
-struct l23_app_info *l23_app_info() +struct l23_app_info *l23_app_info(void) { return &info; } diff --git a/src/host/layer23/src/misc/app_ccch_scan.c b/src/host/layer23/src/misc/app_ccch_scan.c index bde4dc3..dc16359 100644 --- a/src/host/layer23/src/misc/app_ccch_scan.c +++ b/src/host/layer23/src/misc/app_ccch_scan.c @@ -498,7 +498,7 @@ .contribution = "Contributions by Holger Hans Peter Freyther\n", };
-struct l23_app_info *l23_app_info() +struct l23_app_info *l23_app_info(void) { return &info; } diff --git a/src/host/layer23/src/misc/app_cell_log.c b/src/host/layer23/src/misc/app_cell_log.c index 97319fd..069e7d1 100644 --- a/src/host/layer23/src/misc/app_cell_log.c +++ b/src/host/layer23/src/misc/app_cell_log.c @@ -82,7 +82,7 @@ return 0; }
-static int l23_cfg_supported() +static int l23_cfg_supported(void) { return L23_OPT_TAP | L23_OPT_DBG; } @@ -147,7 +147,7 @@ (*band_range)[i][1] = 0; }
-static int l23_cfg_print_help() +static int l23_cfg_print_help(void) { printf("\nApplication specific\n"); printf(" -l --logfile LOGFILE Logfile for the cell log.\n"); @@ -237,7 +237,7 @@ .cfg_print_help = l23_cfg_print_help, };
-struct l23_app_info *l23_app_info() +struct l23_app_info *l23_app_info(void) { return &info; } diff --git a/src/host/layer23/src/misc/app_echo_test.c b/src/host/layer23/src/misc/app_echo_test.c index 531f10c..6d95e65 100644 --- a/src/host/layer23/src/misc/app_echo_test.c +++ b/src/host/layer23/src/misc/app_echo_test.c @@ -55,7 +55,7 @@ .contribution = "Contributions by Holger Hans Peter Freyther\n", };
-struct l23_app_info *l23_app_info() +struct l23_app_info *l23_app_info(void) { return &info; } diff --git a/src/host/layer23/src/mobile/main.c b/src/host/layer23/src/mobile/main.c index 0602654..9533553 100644 --- a/src/host/layer23/src/mobile/main.c +++ b/src/host/layer23/src/mobile/main.c @@ -76,7 +76,7 @@ printf("Usage: %s\n", app); }
-static void print_help() +static void print_help(void) { printf(" Some help...\n"); printf(" -h --help this text\n");
-
laforge