Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30302 )
Change subject: rate_ctr: convert to timerfd ......................................................................
Patch Set 4:
(1 comment)
File src/rate_ctr.c:
https://gerrit.osmocom.org/c/libosmocore/+/30302/comment/c2948534_67cc663c PS3, Line 359: timer_ticks++;
No, why would I do that? The timer_ticks is updated manually every time timer ticks (pun intended). […]
yes, but if a timer is lost due to the CPU being too loaded, you still want to tick the lost event I guess? My understanding is that rate_ctr_group_intv() should be updated to take into account that timer_ticks can be increased more than once at a time, eg by storing last_timer_ticks, incrementing one vari ehre locally, passing it so that it can see if it lot the tick which should have updated it.