Attention is currently required from: laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/33097 ) Change subject: Port to new libosmogsm 'struct osmo_sub_auth_data2' ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File include/osmocom/hlr/db.h: https://gerrit.osmocom.org/c/osmo-hlr/+/33097/comment/40756aba_28f89587 PS2, Line 124: /* Like struct osmo_sub_auth_data2, but the keys are in hexdump representation. intentional rename? is sub_auth_data_str also used for osmo_sub_auth_data2? File src/db_hlr.c: https://gerrit.osmocom.org/c/osmo-hlr/+/33097/comment/9c2efa8b_eadbadd7 PS2, Line 289: if (!osmo_is_hexstr(aud->u.umts.k, 32, 64, true)) { (this patch intends no change of length, right?) -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/33097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I3207c7bfb73e9ff5471e5c26b66639549e4d48a2 Gerrit-Change-Number: 33097 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 05 Jun 2023 22:29:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment