Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29674 ) Change subject: debug: print socket info in log messages ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: Thanks, I wanted to do this for some time now. Some comments though: I'd better enclose the part printing information about the conn into a function or macro, to be able to update/improve the description in the future and simplify it. For instance: LOPGCONNCLI(cli, DLINP, ...) File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/29674/comment/e8ec5fd4_9721d054 PS1, Line 1577: osmo_stream_srv_link_get_sockname(osmo_stream_srv_get_master(conn))); why do you use something different here? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic8c9b0e5a67f0454fe850a80dfd7e6c2b3208b2c Gerrit-Change-Number: 29674 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Oct 2022 13:43:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment