Attention is currently required from: osmith, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34044 )
Change subject: rlcmac: Fix Starting Time rfn->fn calculation ......................................................................
Patch Set 6:
(1 comment)
File src/rlcmac/rlcmac_dec.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/34044/comment/3b4ce618_1c39ca89 PS6, Line 439: 51 * OSMO_MOD_FLR((t3 - t2), 26) + t3 + 51 * 26 * t1p;
AFAICS, this is pretty much a copy-paste from libosmogsm. […]
I prefer keeping it separate since the time structure is not exactly the same (T1 vs T1'). Similarly the function to calculate rfn is also described in a different spec, even if it turns out to be the same formula. So to avoid confusion and since it's only a few lines of code, I prefer keeping it this way.
-
pespin