Attention is currently required from: JPM, dexter, laforge.

fixeria has posted comments on this change by JPM. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email )

Change subject: Fixing 3-digit MNC PlmnAdapter encoding and decoding. Adding test_plmn_adapter. ......................................................................

Patch Set 1:

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/python/pyosmocom/+/38687/comment/78600974_55061... : PS1, Line 8: Adding test_plmn_adapter. Commit summary should be one line followed by an empty line. I would remove this one.

https://gerrit.osmocom.org/c/python/pyosmocom/+/38687/comment/f9f6255f_c988e... : PS1, Line 10: Change-Id: I3811b227d629bd4e051a480c9622967e31f8a376 Add `Related: pysim.git Ib2b586cb570dbe74a617c45c0fca276b08bb075e`

File src/osmocom/construct.py:

https://gerrit.osmocom.org/c/python/pyosmocom/+/38687/comment/2844c233_cb5a9... : PS1, Line 265: """convert a bytes(3) type to BCD string like 262-02 or 262-002.""" Let's add spec. reference here? 3GPP TS 24.008 which section?