Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40590?usp=email ) Change subject: tests: add a simple gtpie_getie() test ...................................................................... Patch Set 2: (23 comments) File tests/gtp/gtpie_test.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/260de123_47f34cdd?us… : PS2, Line 111: static void test_gtpie_getie() Bad function definition - void test_gtpie_getie() should probably be void test_gtpie_getie(void) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/9df455c0_871daf73?us… : PS2, Line 113: union gtpie_member *ie[GTPIE_SIZE] = {}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/f3f3eecf_c8701579?us… : PS2, Line 114: union gtpie_member ie_elem[3] = {}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/fc603da5_83251a9f?us… : PS2, Line 119: OSMO_ASSERT(gtpie_getie(ie, 0, 0) == -1); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/b207e53e_89187a71?us… : PS2, Line 120: OSMO_ASSERT(gtpie_getie(ie, 0, 1) == -1); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/f143f3bf_5a09dc17?us… : PS2, Line 122: OSMO_ASSERT(gtpie_getie(ie, GTPIE_ENODEB_ID, 0) == -1); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/87bef9f9_7926298e?us… : PS2, Line 123: OSMO_ASSERT(gtpie_getie(ie, GTPIE_ENODEB_ID, 1) == -1); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/d49f7ed0_0497de46?us… : PS2, Line 125: ie_elem[0].tv1.t = GTPIE_CAUSE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/395fb0d9_9cdbbb3b?us… : PS2, Line 126: ie_elem[0].tv1.v = GTPIE_CAUSE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/75daf724_30b84eba?us… : PS2, Line 127: ie[0] = &ie_elem[0]; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/1e73c6a5_6f13432a?us… : PS2, Line 129: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 0) == 0); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/f9046e92_c18174ac?us… : PS2, Line 130: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 1) == -1); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/1eafa7ed_8e93cad8?us… : PS2, Line 133: ie_elem[1].tv1.t = GTPIE_CAUSE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/a437ed47_d4d58776?us… : PS2, Line 134: ie_elem[1].tv1.v = GTPIE_CAUSE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/621e7ffa_43a76c0a?us… : PS2, Line 135: ie[2] = &ie_elem[0]; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/c71960ac_cf8946ed?us… : PS2, Line 137: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 0) == 0); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/8982a496_aa903812?us… : PS2, Line 138: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 1) == 2); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/496499ba_e4063649?us… : PS2, Line 141: ie_elem[2].tv1.t = GTPIE_CAUSE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/6af66e69_0f057e0a?us… : PS2, Line 142: ie_elem[2].tv1.v = GTPIE_CAUSE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/24efbf7c_ab3f9886?us… : PS2, Line 143: ie[GTPIE_SIZE - 1] = &ie_elem[0]; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/7dbecb7e_170d538b?us… : PS2, Line 145: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 0) == 0); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/3790e458_e66ae97a?us… : PS2, Line 146: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 1) == 2); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/d7b158cc_acc1b61c?us… : PS2, Line 147: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 2) == GTPIE_SIZE - 1); please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40590?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I5cd45d752592c7133d4452f4e4986783fb17e256 Gerrit-Change-Number: 40590 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 04 Jul 2025 23:23:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No