Attention is currently required from: osmith, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/28023
)
Change subject: abis_nm: run gsm_bts_check_cfg during oml bring up
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bsc/abis_nm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28023/comment/b1e2a3ca_908235d2
PS1, Line 707: abis_nm_rx_get_attr_resp
Are you sure this is the right place to perform such
checks? AFAIR, this messages may be received a […]
I think it's fine checking
everytime there's some new info from any object, since gsm_bts_check_cfg() validates
stuff in any field under bts object (and recursively on objects under it).
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/28023
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I6b1b4ef3e163528ed186050d848ec089a4315a7c
Gerrit-Change-Number: 28023
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 May 2022 10:14:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment