Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611 )

Change subject: icE1usb fw: Add Notify PPS on Carrier Detect option ......................................................................

Patch Set 1:

(2 comments)

File firmware/ice40-riscv/icE1usb/usb_gps.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-e1-hardware-lint-66): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611/comment/e28bfa68_e2776... PS1, Line 157: /* Check if PPS occured */ 'occured' may be misspelled - perhaps 'occurred'?

Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-e1-hardware-lint-66): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611/comment/f38f7f1c_55b82... PS1, Line 173: else if (g_usb_gps.pps.set) else should follow close brace '}'