Attention is currently required from: daniel, laforge, lynxis lazus.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212?usp=email )
Change subject: tcap: Support TID with length 1..4 ......................................................................
Patch Set 2:
(1 comment)
File src/tcap_as_loadshare.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212/comment/50c719cd_05c8b3... : PS2, Line 81: OSMO_ASSERT
why would we want to assert here? Does that mean anyone can crash osmo-stp or libosmo-sigtran by sen […]
My understanding is that since asn1 states "OrigTransactionID ::= [APPLICATION 8] IMPLICIT OCTET STRING (SIZE (1..4) )", if an octet string with size != 1..4 is received, then the decode function will return an error since it's a wrongly encoded message. So in theory it should be impossible to hit this assert.
-
pespin