Attention is currently required from: laforge, pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/29965 )

Change subject: Split gsn_t related APIs out of gtp.{c,h} ......................................................................

Patch Set 2:

(60 comments)

File gtp/gsn.h:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/b725e65e_be46b78d PS2, Line 68: int (*cb_delete_context) (struct pdp_t *); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/543ff95a_56b40c58 PS2, Line 68: int (*cb_delete_context) (struct pdp_t *); function definition argument 'struct pdp_t *' should also have an identifier name

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/36ed6a93_f8791c01 PS2, Line 69: int (*cb_create_context_ind) (struct pdp_t *); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/9d3d2116_f9ff89c0 PS2, Line 69: int (*cb_create_context_ind) (struct pdp_t *); function definition argument 'struct pdp_t *' should also have an identifier name

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/b46a94c1_3f00bdbe PS2, Line 70: int (*cb_unsup_ind) (struct sockaddr_in * peer); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/2b13fcbd_47c96dba PS2, Line 70: int (*cb_unsup_ind) (struct sockaddr_in * peer); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/04a08c52_e87fcf0a PS2, Line 71: int (*cb_extheader_ind) (struct sockaddr_in * peer); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/c072f846_8fded976 PS2, Line 71: int (*cb_extheader_ind) (struct sockaddr_in * peer); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/32689aff_a52d304d PS2, Line 72: int (*cb_ran_info_relay_ind) (struct sockaddr_in *peer, union gtpie_member **ie); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/4b99eb0e_fa84d245 PS2, Line 73: int (*cb_conf) (int type, int cause, struct pdp_t * pdp, void *cbp); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/6356a1bf_f240e83b PS2, Line 73: int (*cb_conf) (int type, int cause, struct pdp_t * pdp, void *cbp); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/eba7023e_15266efc PS2, Line 74: int (*cb_data_ind) (struct pdp_t * pdp, void *pack, unsigned len); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/97e4faa8_8df86f7f PS2, Line 74: int (*cb_data_ind) (struct pdp_t * pdp, void *pack, unsigned len); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/d64de49d_28595798 PS2, Line 75: int (*cb_recovery) (struct sockaddr_in * peer, uint8_t recovery); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/472a9dbf_23b29f50 PS2, Line 75: int (*cb_recovery) (struct sockaddr_in * peer, uint8_t recovery); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/75441155_c600177a PS2, Line 76: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/31900e2a_22c94648 PS2, Line 76: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/fdce0b76_f549b808 PS2, Line 76: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/4d5f1586_d212acdb PS2, Line 77: int (*cb_recovery3) (struct gsn_t *gsn, struct sockaddr_in *peer, struct pdp_t *pdp, uint8_t recovery); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/87eddbce_7c0b82df PS2, Line 120: int (*cb_create_context_ind) (struct Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/c1ea64db_af747dff PS2, Line 124: int (*cb_data_ind) (struct pdp_t * pdp, "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/65cb82ee_88192961 PS2, Line 124: int (*cb_data_ind) (struct pdp_t * pdp, Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/65c42418_2596f758 PS2, Line 127: int (*cb_delete_context) (struct pdp_t * Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/61c7bdbe_8b7f4a76 PS2, Line 133: int (*cb) (struct sockaddr_in * peer)); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/8c186918_a494f7f5 PS2, Line 133: int (*cb) (struct sockaddr_in * peer)); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/e28f0be0_a6752765 PS2, Line 136: int (*cb) (struct sockaddr_in * peer)); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/db6528ea_c0ea0f4b PS2, Line 136: int (*cb) (struct sockaddr_in * peer)); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/c39f3692_ac44d924 PS2, Line 139: int (*cb) (struct sockaddr_in * peer, union gtpie_member **ie)); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/d00eb78b_edcf6c18 PS2, Line 139: int (*cb) (struct sockaddr_in * peer, union gtpie_member **ie)); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/017094b7_4dd94def PS2, Line 142: int (*cb) (int type, int cause, struct pdp_t * pdp, "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/2e45c7dc_a6437537 PS2, Line 142: int (*cb) (int type, int cause, struct pdp_t * pdp, Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/b6c531ba_fc8691a1 PS2, Line 146: int (*cb) (struct sockaddr_in * peer, "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/e0512f75_69b2dc0b PS2, Line 146: int (*cb) (struct sockaddr_in * peer, Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/4f8cd68d_c12302a7 PS2, Line 150: int (*cb) (struct sockaddr_in * peer, "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/853be247_a3acc0de PS2, Line 150: int (*cb) (struct sockaddr_in * peer, Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/67bf5f2c_1d4117ab PS2, Line 151: struct pdp_t * pdp, "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/82390934_485278d1 PS2, Line 155: int (*cb) (struct gsn_t * gsn, struct sockaddr_in * peer, "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/8ca9d718_5d670515 PS2, Line 155: int (*cb) (struct gsn_t * gsn, struct sockaddr_in * peer, "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/b7199d10_7095109d PS2, Line 155: int (*cb) (struct gsn_t * gsn, struct sockaddr_in * peer, Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/d2e8bf1c_2cc935cf PS2, Line 156: struct pdp_t * pdp, "foo * bar" should be "foo *bar"

File gtp/gsn.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/ee427c53_dcbf6e47 PS2, Line 70: #define LOGP_WITH_ADDR(ss, level, addr, fmt, args...) \ macros should not use a trailing semicolon

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/6cb494d8_c86ce4e5 PS2, Line 125: int (*cb) (struct sockaddr_in * peer)) "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/c1fe374b_9cf8cc05 PS2, Line 125: int (*cb) (struct sockaddr_in * peer)) Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/c936cff1_c5928f26 PS2, Line 132: int (*cb) (struct sockaddr_in * peer)) "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/fa576c23_1e289b03 PS2, Line 132: int (*cb) (struct sockaddr_in * peer)) Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/7b21c5f1_e5d549cb PS2, Line 139: int (*cb) (struct sockaddr_in * peer, union gtpie_member **ie)) "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/7125fcee_ce5077a2 PS2, Line 139: int (*cb) (struct sockaddr_in * peer, union gtpie_member **ie)) Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/2a4e8745_793778d2 PS2, Line 147: int gtp_set_cb_delete_context(struct gsn_t *gsn, int (*cb) (struct pdp_t * pdp)) "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/f62a7a4d_a60eae38 PS2, Line 154: int (*cb) (int type, int cause, Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/1941cb21_b1fa4836 PS2, Line 155: struct pdp_t * pdp, void *cbp)) "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/9b025aeb_7fbe720d PS2, Line 162: int (*cb) (struct sockaddr_in * peer, uint8_t recovery)) "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/bfd288c8_049ed37a PS2, Line 162: int (*cb) (struct sockaddr_in * peer, uint8_t recovery)) Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/ffb2792b_dcd93c57 PS2, Line 176: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery)) "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/27923912_ec49d95c PS2, Line 176: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery)) "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/7b8413d4_5e173d9d PS2, Line 176: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery)) Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/226bf75a_99dab6d2 PS2, Line 190: int (*cb_recovery3) (struct gsn_t *gsn, struct sockaddr_in *peer, Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/c730167b_d0b10e43 PS2, Line 198: int (*cb_data_ind) (struct pdp_t * pdp, "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/c8b04df1_9f858548 PS2, Line 198: int (*cb_data_ind) (struct pdp_t * pdp, Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/374c1624_91090adb PS2, Line 517: int (*cb_create_context_ind) (struct pdp_t * Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/4defe9b3_e02628a8 PS2, Line 536: } adding a line without newline at end of file