Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28046 ) Change subject: Introduce new signal S_NM_RUNNING_CHG and implement it for rcarrier,bbtransc ...................................................................... Patch Set 4: (2 comments) File src/osmo-bsc/nm_bb_transc_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28046/comment/25e1364c_d4042300 PS4, Line 43: static void nm_obj_becomes_enabled_disabled(struct gsm_bts_bb_trx *bb_transc, bool running) nm_ob_enable_disable instead of nm_ob_becomes_enabled_disabled? (Same for all other *_becomes_* functions added in this patch) https://gerrit.osmocom.org/c/osmo-bsc/+/28046/comment/6475c649_1c85a42f PS4, Line 280: (unintentionally added a line?) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I206d4c7863a77fbab6a600126742a6a6b8fc3614 Gerrit-Change-Number: 28046 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 May 2022 09:47:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment