Attention is currently required from: daniel, fixeria, laforge, osmith.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39690?usp=email )

Change subject: sccp: Allow marking UNIT-DATA.req Sequence Control param non-presence, set SLS ......................................................................

Patch Set 3:

(1 comment)

File src/sccp_sclc.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/39690/comment/abe421ed_1efb34... : PS3, Line 84: xua->mtp.sls = rand() & 0xf;

this looks like it could by chance become the same sls as in the seq_ctrl present case below. […]

It's totally fine and expected that the same SLS is used from time to time, after all it's only 4 bits. I simply forgot to add the preceding 0 "0x0f" here, but it's actually also correct this way.