Attention is currently required from: canghaiwuhen.

pespin has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41942?usp=email )

Change subject: Modify the QoS length to ensure compatibility with some GPRS modules, such as Air20X. ......................................................................

Patch Set 1:

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-sgsn/+/41942/comment/2734e7c7_dae22725?usp... : PS1, Line 9: Change-Id: Iee49745809195fe7d0897dd1e9cba2427ff7008e Add here:

Related: OS#<HERE-THE-REDMINE-TICKET-NUMBER>

File src/sgsn/gprs_sm.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/41942/comment/4b9f53f4_ca4f622b?usp... : PS1, Line 213: msgb_lv_put(msg, 3, (uint8_t *)&default_qos); I guess the correct approach here would be to see the size of the QoS being used during recieved Activate PDP Context Request, and from the size figure out the release version it is using, and then trim this buffer according to that release version.

Can you add a sample pcap with only the Activate PDP Context Request + Accept mesages to the redmine ticket?