fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28196 ) Change subject: gsm_data: subslots_per_pchan_vamos[GSM_PCHAN_TCH_F]: 2 -> 1 ...................................................................... gsm_data: subslots_per_pchan_vamos[GSM_PCHAN_TCH_F]: 2 -> 1 As far as I can see, multiplexing one TCH/F and two TCH/H sub-slots on one timeslot is not properly implemented yet. At least when trying to 'activate-all-lchan' from the VTY, I see messages like: DCHAN ERROR lchan(0-1-2-TCH_F-shadow1)[0x612000012220]{WAIT_ACTIV_ACK}: (type=TCH_F) Error encoding Channel Number: pchan TCH/F ts 2 ss 1 (VAMOS shadow) The logic basically tries to activate the second shadow sub-slot of TCH/F (not TCH/H!), which indeed does not exist. Change-Id: Ic8243c688385b3b6a3adfbf24ff74b63963bdab2 --- M src/osmo-bsc/gsm_data.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/96/28196/1 diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c index 1d6df12..641a51b 100644 --- a/src/osmo-bsc/gsm_data.c +++ b/src/osmo-bsc/gsm_data.c @@ -639,8 +639,9 @@ [GSM_PCHAN_CCCH] = 0, [GSM_PCHAN_PDCH] = 0, [GSM_PCHAN_CCCH_SDCCH4] = 0, - /* VAMOS: on a TCH/F, there may be a TCH/H shadow */ - [GSM_PCHAN_TCH_F] = 2, + /* FIXME: VAMOS: on a TCH/F, there may be a TCH/H shadow, + * however this is not properly implemented yet. */ + [GSM_PCHAN_TCH_F] = 1, [GSM_PCHAN_TCH_H] = 2, [GSM_PCHAN_SDCCH8_SACCH8C] = 0, [GSM_PCHAN_CCCH_SDCCH4_CBCH] = 0, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28196 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic8243c688385b3b6a3adfbf24ff74b63963bdab2 Gerrit-Change-Number: 28196 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange