Attention is currently required from: fixeria, laforge.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34693?usp=email )
Change subject: transport: print device path/number on initialization failure
......................................................................
Patch Set 6:
(1 comment)
File pySim/transport/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/34693/comment/cf2808bc_d753c987
PS4, Line 330: devinfo = "serial:%s" % opts.device
I don't think that common code should contain clauses for each specific backend. […]
Ack
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/34693?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I3f5387508ccc2aa349adc7aec3d04d8fc977690b
Gerrit-Change-Number: 34693
Gerrit-PatchSet: 6
Gerrit-Owner: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-CC: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Tue, 10 Oct 2023 10:06:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
laforge@osmocom.org
Gerrit-MessageType: comment