Attention is currently required from: fixeria, laforge, pespin.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/34423?usp=email )
Change subject: ASCI: Ignore LAPD frames from MS, while the uplink is not active
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bts/+/34423/comment/698d4c43_783cbfd6
PS2, Line 12: these frames is not desired and not required. If we react on them, we
"A reaction of LAPD is to these frames" […]
Done
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/34423/comment/92273c7a_0c39a421
PS2, Line 1817: /* Do not forward any message from the MS to LAPD while the uplink is
not
I don't really see the problem here. […]
I
did some rephrasing. I hope it it clear now.
https://gerrit.osmocom.org/c/osmo-bts/+/34423/comment/7a4b1b2f_0425ff57
PS2, Line 1820: * these frames is not desired and not required. If we react on them,
we
"A reaction of LAPD is to these frames" […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/34423?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5075115123055b2997481f56ddf473430a1dc9e3
Gerrit-Change-Number: 34423
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Sep 2023 08:26:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment