[L] Change in libosmo-sigtran[master]: tests/vty: Add vty-transcript-test for osmo-stp - gerrit-log

7 Oct 2024


      Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38347?usp=email )
Change subject: tests/vty: Add vty-transcript-test for osmo-stp
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File tests/vty/osmo_stp_test.vty:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38347/comment/21fa68d6_b406a0... :
PS3, Line 104: description .TEXT
This is a generic command from libosmovty (`cfg_description_cmd`), are you sure it should be tested here? I am not strictly against this, but we have had several cases when a change in libosmovty was causing VTY transcript tests to fail in various projects. Likewise below.
-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38347?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: If2f069b9d724038c326f5c35848faa1e9c216fd5
Gerrit-Change-Number: 38347
Gerrit-PatchSet: 3
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Mon, 07 Oct 2024 15:34:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes