Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email ) Change subject: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2 ...................................................................... Patch Set 2: (32 comments) File include/osmocom/vlr/vlr.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/903e94bb_1817c25b?us… : PS2, Line 121: long long unsigned int id; type 'long long unsigned int' should be specified in [[un]signed] [short|int|long|long long] order File src/libvlr/vlr.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/18e46fad_42687710?us… : PS2, Line 238: OSMO_STRBUF_PRINTF(sb, "%sMSISDN-%s", present? ":" : "", vsub->msisdn); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/cfbf8032_0919ba9a?us… : PS2, Line 242: OSMO_STRBUF_PRINTF(sb, "%sTMSI-0x%08X", present? ":" : "", vsub->tmsi); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/cb92549e_e1403b88?us… : PS2, Line 246: OSMO_STRBUF_PRINTF(sb, "%sTMSInew-0x%08X", present? ":" : "", vsub->tmsi_new); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/6adc1cce_8deba49a?us… : PS2, Line 258: char *name = (char*)vlr_subscr_name(vsub); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/fa06b281_2009ae9b?us… : PS2, Line 263: strcpy(name + maxlen - 2, ".."); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/5146457d_dec67a80?us… : PS2, Line 380: vlr_subscr_name(vsub), (e->count - old_use_count) > 0? "+" : "-", e->use, spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/210fbbde_bf9efd18?us… : PS2, Line 705: osmo_plmn_name(&vsub->sgs.last_eutran_plmn) : code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/c1a047cc_287631b1?us… : PS2, Line 810: struct sgsn_subscriber_pdp_data* pdata; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/ac9562d1_75b6661e?us… : PS2, Line 1447: VLR_AUTH_E_MS_ID_IMSI, (void*)mi->imsi); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/e48e0663_fd15e269?us… : PS2, Line 1455: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMSI, (void*)mi->imsi); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/f389965a_f25f00e1?us… : PS2, Line 1457: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMEI, (void*)mi->imei); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/8141dd12_7715a510?us… : PS2, Line 1459: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMEISV, (void*)mi->imeisv); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/672415b9_b00d46e2?us… : PS2, Line 1716: struct vlr_subscr **fsub = (void*)&target->filter_data[LOG_FLT_VLR_SUBSCR]; "(foo*)" should be "(foo *)" File src/libvlr/vlr_access_req_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/2fcac026_db6ab2e1?us… : PS2, Line 111: return par->result? gsm48_reject_value_name(par->result) : "PASSED"; spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/6ce1981d_08b78dfa?us… : PS2, Line 415: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/d27471ce_4a887b81?us… : PS2, Line 421: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/24376f0e_a2b289a8?us… : PS2, Line 496: result = *(enum vlr_ciph_result_cause*)data; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/7c21c885_50dd804e?us… : PS2, Line 791: .in_event_mask = , space prohibited before that ',' (ctx:WxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/8c2c1a2c_aba5fec7?us… : PS2, Line 798: .in_event_mask = , space prohibited before that ',' (ctx:WxE) File src/libvlr/vlr_auth_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/3f91682d_b49c6f6f?us… : PS2, Line 199: res_len, (res_len == vec->res_len)? "valid" : "INVALID on UTRAN"); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/756e8c1f_9284c0bd?us… : PS2, Line 216: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/cf7699de_f4035616?us… : PS2, Line 543: strncpy(vsub->imsi, mi_string, sizeof(vsub->imsi)); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() File src/libvlr/vlr_lu_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/5899dfad_d0b8df06?us… : PS2, Line 160: return (struct vlr_subscr*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/fd59f74c_197f12f5?us… : PS2, Line 272: return (struct vlr_subscr*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/92b3ab2d_307b0044?us… : PS2, Line 667: return (struct lu_compl_vlr_priv*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/a9c33227_760b82f0?us… : PS2, Line 1282: result = *(enum vlr_ciph_result_cause*)data; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/982d6340_83368091?us… : PS2, Line 1404: cause = *(uint8_t*)data; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/6510c6b1_f3c1916a?us… : PS2, Line 1436: cause = *(uint8_t*)data; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/d0e39c5b_b855f107?us… : PS2, Line 1643: return (struct lu_fsm_priv*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/888cf695_f78111e1?us… : PS2, Line 1691: strncpy(lfp->imsi, imsi, sizeof(lfp->imsi)-1); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() File src/libvlr/vlr_sgs.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21555): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/069f787e_8e4ab419?us… : PS2, Line 324: } void function return statements are not generally useful -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d Gerrit-Change-Number: 39560 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 16 Feb 2025 21:40:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No