Attention is currently required from: fixeria, pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 ) Change subject: ms-trx support ...................................................................... Patch Set 5: (371 comments) File Transceiver52M/ms/bladerf_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1db8dbb0_44b1f63a PS5, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/30ee4e45_6ebbca5d PS5, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3e9ae274_4d8e7c51 PS5, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2532f811_414e5bbd PS5, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c9c1c121_f8a02643 PS5, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f5f421c8_0ed5277a PS5, Line 44: out << '(' << std::forward<Arg>(arg); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/968aa5d6_9c00d13a PS5, Line 44: out << '(' << std::forward<Arg>(arg); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/52c1d3d9_25245f08 PS5, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... }; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7bf9117c_d3fdeb44 PS5, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... }; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/11587610_15587a4d PS5, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/06e1c20d_13547e42 PS5, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/49328b5c_751da9ad PS5, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/572fd10b_79135d7a PS5, Line 52: template <class R, class... Args> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/90a12f54_bbe43491 PS5, Line 52: template <class R, class... Args> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d8a2188c_906af860 PS5, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bbe832cd_8e24bb16 PS5, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line, spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d0b28c8b_e8ec233e PS5, Line 56: R rval = func(std::forward<Args>(args)...); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5b0b8eb4_5b75c15e PS5, Line 56: R rval = func(std::forward<Args>(args)...); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8b013167_9649babf PS5, Line 57: if (rval != 0) { suspect code indent for conditional statements (8, 26) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/72c8568b_c9de64c2 PS5, Line 58: std::cerr << ((rval >= 0) ? "OK:" : bladerf_strerror(rval)) << ':' << finame << ':' << line << ':' labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bafd3eb6_f98b8326 PS5, Line 66: #define blade_check(func, ...) exec_and_check(func, #func, __FILE__, __FUNCTION__, __LINE__, __VA_ARGS__) __func__ should be used instead of gcc specific __FUNCTION__ Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/218d72a0_4173f790 PS5, Line 69: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a5fe04a0_016750f5 PS5, Line 69: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/25a8fcea_abee5289 PS5, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4e645578_79ef5ac5 PS5, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ababbeea_c931e2c6 PS5, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!"); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/36dc0271_6ccf6747 PS5, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!"); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/03879f09_550a95a8 PS5, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!"); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c6d0370b_f4a65d2d PS5, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!"); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/117e2823_24cecb7a PS5, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/efe36f96_fcb8b89b PS5, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c3efd40c_c92c7826 PS5, Line 82: blade_usb_message<T> m[SZ]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/851a57aa_f3b4ee04 PS5, Line 82: blade_usb_message<T> m[SZ]; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/58bd648b_3ae2236e PS5, Line 83: int actual_samples_per_msg() Bad function definition - int actual_samples_per_msg() should probably be int actual_samples_per_msg(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bb9ba8b8_a01610d5 PS5, Line 83: int actual_samples_per_msg() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d399514a_a60e9705 PS5, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/770236dd_389b9904 PS5, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/496f604d_65e08c9f PS5, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1b87d225_9561e365 PS5, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/51706849_93806949 PS5, Line 87: int actual_samples_per_buffer() Bad function definition - int actual_samples_per_buffer() should probably be int actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d81b7e13_976d3b68 PS5, Line 87: int actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a4019327_f5233e0c PS5, Line 91: int samples_per_buffer() Bad function definition - int samples_per_buffer() should probably be int samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2afd99ca_bb3b3645 PS5, Line 91: int samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3a4a6389_41cd3e9f PS5, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bb06b62d_245b3e61 PS5, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/19054ec8_249d7770 PS5, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e0d512ea_dbc06bd2 PS5, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/06476368_77eb48c4 PS5, Line 95: int num_msgs_per_buffer() Bad function definition - int num_msgs_per_buffer() should probably be int num_msgs_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/682ed0d5_b72c5c4e PS5, Line 95: int num_msgs_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/be93be05_d44b81e5 PS5, Line 99: auto get_first_ts() Bad function definition - auto get_first_ts() should probably be auto get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c6f8a375_01f4f73f PS5, Line 99: auto get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/550ed6f2_bc691961 PS5, Line 103: constexpr auto *getsampleoffset(int ofs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f22bc2a9_b4704a66 PS5, Line 109: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9723210e_672d9343 PS5, Line 118: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1cc5c7e6_ac8f8209 PS5, Line 156: int write_n_burst(blade_sample_type *in, int num, uint64_t first_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9f601169_7bf3b14d PS5, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/74537a43_6f23f3f2 PS5, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e2f5c277_01584ab7 PS5, Line 178: static blade_otw_buffer<SZ / 512, T> x; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c2db1b09_b69365e9 PS5, Line 178: static blade_otw_buffer<SZ / 512, T> x; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9611073d_0dbfcff2 PS5, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f9337b12_ec081468 PS5, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4148c131_9ed248e0 PS5, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f48fa2cb_88dbbf84 PS5, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8a2a750a_effb99c8 PS5, Line 185: template <typename T> struct blade_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/41ef42e3_34dcab89 PS5, Line 185: template <typename T> struct blade_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6e59edee_5860179d PS5, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7ce61203_24ff5c4b PS5, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/874357bb_44cd5ca3 PS5, Line 202: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9b45cb4b_57cc16fc PS5, Line 223: void close_device() Bad function definition - void close_device() should probably be void close_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6b025839_cb52215e PS5, Line 223: void close_device() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6348252a_86efdd80 PS5, Line 242: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c7228ade_249ed0a1 PS5, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b93f72e9_c5042e2d PS5, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1fefae16_9d664da4 PS5, Line 250: std::cerr << "open failed, device missing?" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e85ec107_46148a9b PS5, Line 254: std::cerr << "open failed, only superspeed (usb3) supported!" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/34593d7c_92d269fb PS5, Line 271: std::cerr << "unable to lock refclk!" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bb008d79_4c5bce76 PS5, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ee16de6a_abe812f2 PS5, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1ddc54b7_576eeaa1 PS5, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/04c815c8_d3d65033 PS5, Line 316: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5d5eb861_8be1231a PS5, Line 318: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bf152a45_40677e10 PS5, Line 320: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e09d46ec_7465b28d PS5, Line 323: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/679d5e1a_a86ad697 PS5, Line 325: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d105ff57_3ce5148a PS5, Line 327: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cfcd7e01_53f9fbe9 PS5, Line 330: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2018b5d3_13af9aaf PS5, Line 335: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0df44b48_ff4ab5da PS5, Line 338: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ee87d245_67afcd57 PS5, Line 340: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/02c31869_59af9a57 PS5, Line 343: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c2f16844_2f6d3577 PS5, Line 346: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/84635d5d_4e47967b PS5, Line 348: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ede3335b_4b1a677c PS5, Line 351: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7f25130e_a53c2765 PS5, Line 356: static void check_timestamp(dev_buf_t *rcd) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/116f275a_83c9a60a PS5, Line 363: } else if (last_ts + rcd->actual_samples_per_buffer() != rcd->m[0].ts) { suspect code indent for conditional statements (16, 34) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e44a6093_30f18b92 PS5, Line 364: std::cerr << "RX Overrun!" << last_ts << " " << rcd->actual_samples_per_buffer() << " " labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/07b6c580_ec6b477e PS5, Line 372: bladerf_stream_cb getrxcb(bh_fn_t rxbh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/39536ede_a28832d7 PS5, Line 376: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta, space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5b040b78_ae362a7a PS5, Line 377: void *samples, size_t num_samples, void *user_data) -> void * { spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f82cba64_6dca1ece PS5, Line 392: bladerf_stream_cb gettxcb(bh_fn_t txbh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9e9b50d9_5c7307e5 PS5, Line 396: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta, space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fc887f99_212def38 PS5, Line 397: void *samples, size_t num_samples, void *user_data) -> void * { spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/14cfae85_47418d42 PS5, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/45c0ceaf_c7a8ca1b PS5, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/02c6c504_f7473fe2 PS5, Line 408: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c547175d_8f33ed07 PS5, Line 410: auto fn = [this] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3e12daa0_3e976577 PS5, Line 414: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9299f624_ed906ce2 PS5, Line 420: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e76c69d3_b40f720a PS5, Line 422: auto fn = [this] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aa0e9a7b_297da01a PS5, Line 426: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eecd9c3c_430cb1a1 PS5, Line 433: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9450ba55_ac046910 PS5, Line 435: //get empty bufer from list 'bufer' may be misspelled - perhaps 'buffer'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a7e51d49_c5306b1d PS5, Line 436: tx_buf_q_type::elem_t rcd; labels should not be indented File Transceiver52M/ms/itrq.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/54e7aec3_0fbf56eb PS5, Line 36: template <bool block_read, bool block_write> class spsc_cond_detail { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dbe1738d_83bccfb1 PS5, Line 36: template <bool block_read, bool block_write> class spsc_cond_detail { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f225ad5_9540fcd8 PS5, Line 37: std::condition_variable cond_r, cond_w; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c95bc8ee_547bc069 PS5, Line 38: std::mutex lr, lw; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c9a760a5_e7175182 PS5, Line 39: std::atomic_int r_flag, w_flag; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/760eb66c_873e4692 PS5, Line 41: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d1e7d442_a3c1bc9f PS5, Line 42: explicit spsc_cond_detail() : r_flag(0), w_flag(0) Bad function definition - explicit spsc_cond_detail() should probably be explicit spsc_cond_detail(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7d6c51d1_0533d05e PS5, Line 50: ssize_t spsc_check_r() Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/81e18105_3bc3f61f PS5, Line 50: ssize_t spsc_check_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dd01c310_9dabb688 PS5, Line 52: std::unique_lock<std::mutex> lk(lr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ef39ac13_39291631 PS5, Line 52: std::unique_lock<std::mutex> lk(lr); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ce3bbad5_26c5cf01 PS5, Line 52: std::unique_lock<std::mutex> lk(lr); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6e9022fd_c733801d PS5, Line 58: ssize_t spsc_check_w() Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7ffbfb1b_99c6e037 PS5, Line 58: ssize_t spsc_check_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2c080bca_97d57928 PS5, Line 60: std::unique_lock<std::mutex> lk(lw); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/da46b721_58471d4d PS5, Line 60: std::unique_lock<std::mutex> lk(lw); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/70611e16_148cda92 PS5, Line 60: std::unique_lock<std::mutex> lk(lw); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1f44127f_16680c52 PS5, Line 66: void spsc_notify_r() Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d464b584_5861fb0a PS5, Line 66: void spsc_notify_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/61b27a40_8d9a1e61 PS5, Line 68: std::unique_lock<std::mutex> lk(lr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/79c14c14_28139345 PS5, Line 68: std::unique_lock<std::mutex> lk(lr); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9a4dd0ce_73364a2b PS5, Line 68: std::unique_lock<std::mutex> lk(lr); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f5dbc7ba_710c70f9 PS5, Line 72: void spsc_notify_w() Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4aef8df6_9c12ba6f PS5, Line 72: void spsc_notify_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8e634151_1d549726 PS5, Line 74: std::unique_lock<std::mutex> lk(lw); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/271da110_959f38f5 PS5, Line 74: std::unique_lock<std::mutex> lk(lw); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/74362a36_84fc294a PS5, Line 74: std::unique_lock<std::mutex> lk(lw); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ece62726_b1c760b1 PS5, Line 81: template <bool block_read, bool block_write> class spsc_efd_detail { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fb4818d2_d2a991d7 PS5, Line 81: template <bool block_read, bool block_write> class spsc_efd_detail { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/72fb96cc_74cafcc7 PS5, Line 84: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4e1c8eb4_0d802b44 PS5, Line 85: explicit spsc_efd_detail() Bad function definition - explicit spsc_efd_detail() should probably be explicit spsc_efd_detail(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/18be9f2e_f774b6c4 PS5, Line 96: ssize_t spsc_check_r() Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b1ae109d_3930dead PS5, Line 96: ssize_t spsc_check_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bc9a8451_cb9c64e5 PS5, Line 101: ssize_t spsc_check_w() Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bfc2d9dc_b0a78b58 PS5, Line 101: ssize_t spsc_check_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/51c21133_c8ec7f21 PS5, Line 106: void spsc_notify_r() Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3c230a01_2c8f9bd6 PS5, Line 106: void spsc_notify_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2a17c87c_c107cc1a PS5, Line 111: void spsc_notify_w() Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5bfbc535_dd2c1696 PS5, Line 111: void spsc_notify_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f95d18a_1fe9bd6a PS5, Line 116: int get_r_efd() Bad function definition - int get_r_efd() should probably be int get_r_efd(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5626cf56_047e624e PS5, Line 116: int get_r_efd() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3be8df4c_b7531a29 PS5, Line 120: int get_w_efd() Bad function definition - int get_w_efd() should probably be int get_w_efd(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9033449d_fcf696bd PS5, Line 120: int get_w_efd() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/99259aef_a6e48e15 PS5, Line 126: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7609fb3a_3bef3122 PS5, Line 126: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dca0ecb8_f8e4f2b8 PS5, Line 126: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/857fa8a6_c48722c9 PS5, Line 126: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ed3aaf5c_9289dad9 PS5, Line 127: class spsc : public T<block_read, block_write> { spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4dd9edcf_be12d6ac PS5, Line 127: class spsc : public T<block_read, block_write> { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ed865534_d50d9af1 PS5, Line 129: std::atomic<unsigned int> readptr; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2699685f_2c39170e PS5, Line 129: std::atomic<unsigned int> readptr; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ca2bd0f7_c5e36677 PS5, Line 129: std::atomic<unsigned int> readptr; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4388bf24_84723f84 PS5, Line 130: std::atomic<unsigned int> writeptr; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5fba20bc_8d67b653 PS5, Line 130: std::atomic<unsigned int> writeptr; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9cb41f55_f59b991e PS5, Line 130: std::atomic<unsigned int> writeptr; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/59c9b9d5_b9e6d38a PS5, Line 134: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/32e12996_cca4b5a3 PS5, Line 135: using base_t = T<block_read, block_write>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f6be1c87_1cb506ed PS5, Line 135: using base_t = T<block_read, block_write>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0bf4acbf_d464d529 PS5, Line 137: explicit spsc() : readptr(0), writeptr(0) Bad function definition - explicit spsc() should probably be explicit spsc(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9a02be6c_8f96914f PS5, Line 148: bool spsc_push(const ELEM *elem) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/297b4ddf_7fd74690 PS5, Line 155: base_t::spsc_check_w(); /* blocks, ensures next (!) call succeeds */ labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cd91910c_e95d16bc PS5, Line 161: base_t::spsc_notify_r(); /* fine after release */ labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2cd18950_ffd435b7 PS5, Line 168: bool spsc_pop(ELEM *elem) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/42436621_6cfec3d2 PS5, Line 180: base_t::spsc_notify_w(); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f67910a_7b2e4afb PS5, Line 187: ssize_t spsc_prep_pop() Bad function definition - ssize_t spsc_prep_pop() should probably be ssize_t spsc_prep_pop(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/333f6965_4e0dc9f9 PS5, Line 187: ssize_t spsc_prep_pop() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78199df0_1ed5914b PS5, Line 195: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ba11aafe_1775d336 PS5, Line 195: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c5bac7dc_790cd586 PS5, Line 196: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {}; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/49baf8a2_a3836f96 PS5, Line 196: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {}; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0762796e_acc63e8e PS5, Line 197: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c1ebdfa5_069ab464 PS5, Line 197: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a3671b8b_bfa8a720 PS5, Line 198: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; adding a line without newline at end of file Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8a28829e_0743a45b PS5, Line 198: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/37f88327_c5cfd234 PS5, Line 198: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; spaces required around that '>' (ctx:VxW) File Transceiver52M/ms/ms.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1ec3e54d_f60b40d1 PS5, Line 33: #define BASET blade_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9c676523_f45c2555 PS5, Line 33: #define BASET blade_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4378adb4_577c5d29 PS5, Line 36: #define BASET uhd_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/11ca7333_4b7c20a7 PS5, Line 36: #define BASET uhd_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8de4afa0_e90e97d8 PS5, Line 48: template <typename T> void clamp_array(T *start2, unsigned int len, T max) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cd77bbd0_c0fe1342 PS5, Line 48: template <typename T> void clamp_array(T *start2, unsigned int len, T max) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/23306f2e_50359168 PS5, Line 48: template <typename T> void clamp_array(T *start2, unsigned int len, T max) need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ed6a7881_b0171029 PS5, Line 56: template <typename DST_T, typename SRC_T, typename ST> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/476c6920_7592133f PS5, Line 56: template <typename DST_T, typename SRC_T, typename ST> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6b36b4a8_9e5b7a77 PS5, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3ad9239b_5631ad7f PS5, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a3ecc843_a733f06a PS5, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4ccb25c5_27d9d64c PS5, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7caac0e5_d6f77730 PS5, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3888e4c5_6babd7cc PS5, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/549a5e08_1afa9e84 PS5, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8be87cd5_6645f915 PS5, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c3a1a23f_bf25aebb PS5, Line 62: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cb3571f9_42103fb1 PS5, Line 62: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9e5ca996_c998f892 PS5, Line 64: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2e3ca29e_051bdc69 PS5, Line 64: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/26b96ad3_2484b8c9 PS5, Line 71: GSM::Time gsmts; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/25f0645b_adc4b443 PS5, Line 78: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/518b700f_95282c96 PS5, Line 78: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4026e79_e5f6bd86 PS5, Line 83: std::ostream null_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/24ed4bb7_ca153821 PS5, Line 85: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dfc540a4_e622f4ca PS5, Line 86: dummylog() : null_stream(this){}; space required before the open brace '{' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9d80f2e7_93c6d562 PS5, Line 88: std::ostream &operator()() need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3e9bb51c_763f4ce4 PS5, Line 88: std::ostream &operator()() labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/02322bab_09ac27d0 PS5, Line 100: GSM::Time global_time_keeper; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ddf68a5_603b4239 PS5, Line 102: std::mutex m; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/28aa546d_8f484a2a PS5, Line 104: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/47522a74_20db3d05 PS5, Line 109: void set(GSM::Time t, int64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/54de7741_018f1afa PS5, Line 111: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2757df8b_3f317be4 PS5, Line 111: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7f6a6e13_c6869689 PS5, Line 111: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2629228d_a76f7c0e PS5, Line 115: void inc_both() Bad function definition - void inc_both() should probably be void inc_both(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/de7c390b_c5245ee7 PS5, Line 115: void inc_both() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5138f0d9_1f6278dd PS5, Line 117: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/08763be4_50c79a37 PS5, Line 117: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d5e50da_f1bd6437 PS5, Line 117: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9ed4d34c_7fbe873b PS5, Line 121: void inc_and_update(int64_t new_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4445e1a2_6dd0af05 PS5, Line 123: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/51366fb9_0a3b4d5a PS5, Line 123: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f9a61c0e_d8f4d8c4 PS5, Line 123: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/12351452_e34ca89d PS5, Line 128: void inc_and_update_safe(int64_t new_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/17e3befa_9c48d6a8 PS5, Line 130: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/86791907_30894136 PS5, Line 130: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ac1c912d_010c84fe PS5, Line 130: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8c8aa077_01bac002 PS5, Line 138: void dec_by_one() Bad function definition - void dec_by_one() should probably be void dec_by_one(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ad843c14_eeebf485 PS5, Line 138: void dec_by_one() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dc1bf536_6dd799a3 PS5, Line 140: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/51286627_84396b1e PS5, Line 140: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5fd901a0_36938d56 PS5, Line 140: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c263844a_9691d3d5 PS5, Line 144: auto get_ts() Bad function definition - auto get_ts() should probably be auto get_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/50f41d89_f2f32512 PS5, Line 144: auto get_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f5f3a606_432e2657 PS5, Line 146: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f3ba403_814e8c15 PS5, Line 146: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/42855d83_b92e38f4 PS5, Line 146: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/540501df_4e5de12f PS5, Line 149: auto gsmtime() Bad function definition - auto gsmtime() should probably be auto gsmtime(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e05f7c34_62ed3a02 PS5, Line 149: auto gsmtime() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d719d532_f0f1ecce PS5, Line 151: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/49e4ddee_2dd7414d PS5, Line 151: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/012c94e7_c44366a6 PS5, Line 151: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/af0a04fe_5ada53a6 PS5, Line 154: void get_both(GSM::Time *t, int64_t *ts) need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d76c3764_2eaf3424 PS5, Line 154: void get_both(GSM::Time *t, int64_t *ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/54617b2b_01de1889 PS5, Line 156: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3dde495_38b25bd0 PS5, Line 156: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a78ec7ff_f40cda0d PS5, Line 156: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ca10aef_0f349275 PS5, Line 162: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/91981a7f_a90c3252 PS5, Line 162: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e03cfd59_9a80ba92 PS5, Line 172: std::thread rx_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f6994328_ba82ee68 PS5, Line 173: std::thread tx_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/13b159ce_9793d117 PS5, Line 174: std::thread *calcrval_task; need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1bc6db78_648aaefe PS5, Line 174: std::thread *calcrval_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f036ea89_51b91c44 PS5, Line 185: std::atomic<bool> rcv_done; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/84d56499_066d5a0c PS5, Line 185: std::atomic<bool> rcv_done; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4eee4eca_85500944 PS5, Line 185: std::atomic<bool> rcv_done; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/274418e8_8ea0d95b PS5, Line 186: std::atomic<bool> sch_thread_done; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/91db345a_4bcd5152 PS5, Line 186: std::atomic<bool> sch_thread_done; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e83d7ebb_9061d270 PS5, Line 186: std::atomic<bool> sch_thread_done; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9126233d_c66932fa PS5, Line 193: void start(); Bad function definition - void start() should probably be void start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c19d12c4_1169d3f4 PS5, Line 194: std::atomic<bool> upper_is_ready; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fd27826a_729c1606 PS5, Line 194: std::atomic<bool> upper_is_ready; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6fad4790_7893f5df PS5, Line 194: std::atomic<bool> upper_is_ready; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bd0d0ed1_61ee9b7d PS5, Line 197: bool handle_sch_or_nb(); Bad function definition - bool handle_sch_or_nb() should probably be bool handle_sch_or_nb(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/edbac8b7_66e6afbb PS5, Line 203: int init_device(); Bad function definition - int init_device() should probably be int init_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8acae8bb_a7dc21e2 PS5, Line 204: int init_dev_and_streams(); Bad function definition - int init_dev_and_streams() should probably be int init_dev_and_streams(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/27bcaf3b_ab0d559a PS5, Line 205: void stop_threads(); Bad function definition - void stop_threads() should probably be void stop_threads(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eaa29e0d_27a65334 PS5, Line 207: void *tx_cb(); Bad function definition - void *tx_cb() should probably be void *tx_cb(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9bd2cafa_17113896 PS5, Line 208: void maybe_update_gain(one_burst &brst); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/efc3363e_575a3591 PS5, Line 221: bh_fn_t rx_bh(); Bad function definition - bh_fn_t rx_bh() should probably be bh_fn_t rx_bh(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/529b69d9_3d21d790 PS5, Line 222: bh_fn_t tx_bh(); Bad function definition - bh_fn_t tx_bh() should probably be bh_fn_t tx_bh(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1bc176db_e4488b0d PS5, Line 225: void set_ta(int val) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/325be44e_513a3069 PS5, Line 231: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ac8aa3f3_c461eeb5 PS5, Line 236: void set_name_aff_sched(std::thread::native_handle_type h, const char *name, int cpunum, int schedtype, open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/558d55f9_9cfb0507 PS5, Line 248: std::cerr << name << " affinity: errreur! " << std::strerror(errno); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dae4bd94_6da19f01 PS5, Line 256: std::cerr << name << " sched: errreur! " << std::strerror(errno); labels should not be indented File Transceiver52M/ms/ms_rx_burst.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9ab20db8_87a27938 PS5, Line 25: void rcv_bursts_test(rx_queue_t *q, unsigned int *tsc, int scale); adding a line without newline at end of file File Transceiver52M/ms/ms_upper.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/51600643_2da67da7 PS5, Line 36: bool driveControl(); Bad function definition - bool driveControl() should probably be bool driveControl(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bb8cbb03_9112e6a0 PS5, Line 37: void driveReceiveFIFO(); Bad function definition - void driveReceiveFIFO() should probably be void driveReceiveFIFO(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b89098fd_d31fcf51 PS5, Line 38: void driveTx(); Bad function definition - void driveTx() should probably be void driveTx(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d432776e_2ac07d58 PS5, Line 40: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7a9cbf4f_cb295e52 PS5, Line 40: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ddf5347a_3eb851b9 PS5, Line 40: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d02e3356_2afd83f2 PS5, Line 40: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); function definition argument 'int' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6c0b690c_b37e2f2f PS5, Line 40: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); function definition argument 'int' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/35f9432c_1cb9875a PS5, Line 42: std::thread thr_control, thr_rx, thr_tx; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1469fdd4_54bfa1cc PS5, Line 44: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e7718948_463e9197 PS5, Line 45: void start_threads(); Bad function definition - void start_threads() should probably be void start_threads(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5984dd6e_46e66669 PS5, Line 46: void start_lower_ms(); Bad function definition - void start_lower_ms() should probably be void start_lower_ms(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1fec74d9_3324f28c PS5, Line 48: upper_trx(){}; space required before the open brace '{' File Transceiver52M/ms/sch.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/83d7ec13_f1edf6f0 PS5, Line 130: int gsm_fcch_check_ts(int ts, int fn) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4e5d175_8c0181dc PS5, Line 134: int gsm_sch_check_ts(int ts, int fn) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2e3b3951_72b0b56d PS5, Line 205: #if 1 Consider removing the #if 1 and its #endif Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9353ebe5_a4b59252 PS5, Line 210: float a, b, c, d, ang, avg = 0.0f; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4209a20f_95280c93 PS5, Line 235: ang = b - a; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fc7002e3_aa187332 PS5, Line 237: if (ang > M_PI) 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1d6b5664_6e8046d2 PS5, Line 238: ang -= 2 * M_PI; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cd468a0b_cd300fe0 PS5, Line 239: else if (ang < -M_PI) 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dfd908d7_80afda47 PS5, Line 240: ang += 2 * M_PI; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2c27241b_0201ae25 PS5, Line 242: avg += ang; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/de14c8cd_8348239f PS5, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b5d7c93a_67617f34 PS5, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e077d1a4_4723ecc7 PS5, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b92a056f_8a47f058 PS5, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/863666aa_3d11a290 PS5, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f3d1140b_d6405b23 PS5, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ceb0f45d_95a5cad8 PS5, Line 314: static __attribute__((constructor)) void init() Bad function definition - void init() should probably be void init(void) File Transceiver52M/ms/uhd_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0177c3bb_e82748ed PS5, Line 35: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/83670202_f71c6641 PS5, Line 35: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6c73b5f9_02c86b5a PS5, Line 41: uhd::rx_metadata_t *md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/19054522_3995a58f PS5, Line 43: auto actual_samples_per_buffer() Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0ccf1e62_c650c112 PS5, Line 43: auto actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fcc13b2f_69628742 PS5, Line 47: long get_first_ts() Bad function definition - long get_first_ts() should probably be long get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/22c2bceb_6a448cc6 PS5, Line 47: long get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a2f2c456_cc2b321f PS5, Line 51: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4a62d528_45995bb7 PS5, Line 56: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a82190d2_f1cac73a PS5, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/05d03bb2_a0fe6484 PS5, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f5dc41a4_f8a9bf71 PS5, Line 69: template <typename T> struct uhd_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ea5212d3_8e9077b4 PS5, Line 69: template <typename T> struct uhd_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f9b5d20_914342f8 PS5, Line 70: uhd::usrp::multi_usrp::sptr dev; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d2af54d3_3feca4de PS5, Line 71: uhd::rx_streamer::sptr rx_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/55860bc6_5018168d PS5, Line 72: uhd::tx_streamer::sptr tx_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/54f8903f_8f82bfec PS5, Line 74: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/281fb68a_feedc529 PS5, Line 74: std::vector<blade_sample_type *> pkt_ptrs; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d51acdd4_b80957e2 PS5, Line 74: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6a1f182e_50e73e3d PS5, Line 74: std::vector<blade_sample_type *> pkt_ptrs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1387cc08_cfea3dd7 PS5, Line 90: void close_device() Bad function definition - void close_device() should probably be void close_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9f26ac43_88fa423b PS5, Line 90: void close_device() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7139e7ef_b4541438 PS5, Line 95: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bef414a1_0792f637 PS5, Line 102: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fcba89b4_809dfa06 PS5, Line 109: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2ceae6f0_05158b04 PS5, Line 114: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/99b27f0e_d55c6cfd PS5, Line 122: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/93768f7d_985360ca PS5, Line 130: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/033d6cc6_69669b6c PS5, Line 135: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7e393a06_90ef0c1f PS5, Line 145: std::string args = {}; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/de19d0e3_0ed2004a PS5, Line 148: std::cout << "Using Device: " << dev->get_pp_string() << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ac0897f5_32a193cf PS5, Line 153: uhd::tune_request_t tune_request(freq, 0); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/42f55603_53e8142a PS5, Line 162: std::this_thread::sleep_for(std::chrono::milliseconds(lock_delay_ms)); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d5673f29_013b6aab PS5, Line 164: uhd::stream_args_t stream_args("sc16", "sc16"); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cba19fd5_1bc7d521 PS5, Line 166: uhd::stream_args_t stream_args2("sc16", "sc16"); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e7e7b555_fdfcad3b PS5, Line 177: void *rx_cb(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/85cdd2fc_3512219f PS5, Line 182: uhd::rx_metadata_t md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/04b0a051_dab8721b PS5, Line 186: std::cerr << boost::format("Timeout while streaming") << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/66f499a3_3764d68b PS5, Line 190: std::cerr << boost::format("Got an overflow indication\n") << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3cc63b47_bd4ac001 PS5, Line 194: std::cerr << str(boost::format("Receiver error: %s") % md.strerror()); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f744e07f_bfc717d0 PS5, Line 209: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f2f41bd4_306436bd PS5, Line 211: auto fn = [this, burst_handler] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5b532910_d069e1e4 PS5, Line 214: uhd::stream_cmd_t stream_cmd(uhd::stream_cmd_t::STREAM_MODE_START_CONTINUOUS); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/32411831_9d318e2c PS5, Line 225: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1a64660d_2a59a031 PS5, Line 227: auto fn = [] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/32c5f5e0_0acb7e85 PS5, Line 232: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/69f15d6c_272acb1a PS5, Line 234: uhd::tx_metadata_t m = {}; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/db1a0811_6372155b PS5, Line 239: std::vector<void *> ptrs(1, buffer); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d4dc2c30_ae29e56e PS5, Line 239: std::vector<void *> ptrs(1, buffer); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2f146ebd_423e1f92 PS5, Line 239: std::vector<void *> ptrs(1, buffer); spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/59a92d75_4c3d99bb PS5, Line 239: std::vector<void *> ptrs(1, buffer); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1df28b57_6572157d PS5, Line 243: uhd::async_metadata_t async_md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9b821bdd_f4c389e2 PS5, Line 248: std::cout << (tx_ack ? "yay" : "nay") << " " << async_md.time_spec.to_ticks(rxticks) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fe0fe850_aeb0791a PS5, Line 251: }; adding a line without newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Comment-Date: Fri, 02 Dec 2022 11:24:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment