Attention is currently required from: fixeria, pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40692?usp=email )

Change subject: routing area: add LOGRA() logging macro ......................................................................

Patch Set 3:

(2 comments)

File include/osmocom/sgsn/gprs_routing_area.h:

https://gerrit.osmocom.org/c/osmo-sgsn/+/40692/comment/77f959ad_ae4a8037?usp... : PS2, Line 15: char __log_rai_buf[32]; \

are you sure 32 is enough? sounds a bit tight.

I used the same size as libosmocore uses it in osmo_rai_name2(). But it is enought because it should be only 18 chars including '\0'. 901-070-65535-254

https://gerrit.osmocom.org/c/osmo-sgsn/+/40692/comment/e587bd79_b3e233ea?usp... : PS2, Line 16: osmo_rai_name2_buf

Yeah, I had similar problems in libosmo-sigtran. I'm in favour of using _buf() here. […]

Done