Attention is currently required from: fixeria, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/40692?usp=email )
Change subject: routing area: add LOGRA() logging macro
......................................................................
Patch Set 3:
(2 comments)
File include/osmocom/sgsn/gprs_routing_area.h:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40692/comment/77f959ad_ae4a8037?us… :
PS2, Line 15: char __log_rai_buf[32]; \
are you sure 32 is enough? sounds a bit tight.
I
used the same size as libosmocore uses it in osmo_rai_name2().
But it is enought because it should be only 18 chars including '\0'.
901-070-65535-254
https://gerrit.osmocom.org/c/osmo-sgsn/+/40692/comment/e587bd79_b3e233ea?us… :
PS2, Line 16: osmo_rai_name2_buf
Yeah, I had similar problems in libosmo-sigtran.
I'm in favour of using _buf() here. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-sgsn/+/40692?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ib287b70c34b21ce64bc864f69fcf6af5fa0698b9
Gerrit-Change-Number: 40692
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 01 Aug 2025 12:56:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>