Attention is currently required from: daniel, fixeria, laforge.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41508?usp=email )
Change subject: card_key_provider: add PostgreSQL support ......................................................................
Patch Set 9:
(2 comments)
File contrib/csv-to-pgsql.py:
https://gerrit.osmocom.org/c/pysim/+/41508/comment/ac29290a_d7330054?usp=ema... : PS8, Line 37: PQSQL
PGSQL or PSQL are usual acronyms for postgres. […]
Done
https://gerrit.osmocom.org/c/pysim/+/41508/comment/72a70abc_64ec120c?usp=ema... : PS8, Line 261: str(Path.home()) + "/.osmocom/pysim/card_data_pqsql.cfg"
Not critical, but I guess the clean/pythonic way would be to use `os.path. […]
Thanks, having the user name in the helptext is indeed something we should avoid. I remember having problems with resolving ~, but os.path.expanduser() works well when I apply it on the path when accessing opts.pqsql.
I have also fixed this for pySim-shell.py