Attention is currently required from: laforge, osmith.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35172?usp=email )

Change subject: soft_uart: implement modem status lines and flow control ......................................................................

Patch Set 3:

(2 comments)

File src/core/soft_uart.c:

https://gerrit.osmocom.org/c/libosmocore/+/35172/comment/a3f2ac49_03a28e9a PS2, Line 403: if (cfg->status_change_cb != NULL) {

call osmo_soft_uart_set_status instead?

Good idea, thanks! Done.

File tests/soft_uart/soft_uart_test.c:

https://gerrit.osmocom.org/c/libosmocore/+/35172/comment/d2d6c854_a9593009 PS2, Line 409: printf("expecting osmo_soft_uart_tx_ubits() to yeild nothing\n");

yeild -> yield? same below a couple of times

Done