Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/40295?usp=email ) Change subject: Introduce tests/osmo-config-merge testsuite ...................................................................... Patch Set 4: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/1ea205f3_6972069e?… : PS4, Line 7: testsuite There's several reasons: * This is testing an app, not some parts of the library. Hence, it allows specifically testing the app, or skipping it later on if user is not interested about it. * Given this app only function is to process text files, it feels natural to use the testsuite since it provides all the match and diff features. The natural way to test it is writing several input tests and validating the output. This means we'll potentially end up with tons of tests in the testsuite validating different scenarios. * Te tests/testsuite is already quite convoluted with tons of different stuff Does that mean it coudln't be in testsuite/test? It could be there. IMHO it's better to have it in a separate testsuite for the above reasons. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia172d4c280f4bae1b411ad805cca02355ca7fcc9 Gerrit-Change-Number: 40295 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 May 2025 11:57:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>