Attention is currently required from: fixeria.

View Change

1 comment:

• Commit Message:

  • Patch Set #4, Line 7: testsuite

    Can you explain why is it a whole new testsuite and not just part of the existing testsuite?

    There's several reasons:

    • This is testing an app, not some parts of the library. Hence, it allows specifically testing the app, or skipping it later on if user is not interested about it.
    • Given this app only function is to process text files, it feels natural to use the testsuite since it provides all the match and diff features. The natural way to test it is writing several input tests and validating the output. This means we'll potentially end up with tons of tests in the testsuite validating different scenarios.
    • Te tests/testsuite is already quite convoluted with tons of different stuff

    
    Does that mean it coudln't be in testsuite/test? It could be there. IMHO it's better to have it in a separate testsuite for the above reasons.

To view, visit change 40295. To unsubscribe, or for help writing mail filters, visit settings.