Attention is currently required from: pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-upf/+/27222
)
Change subject: libosmo-pfcp: implement/generate TLV and IE value coding
......................................................................
Patch Set 5:
(1 comment)
File include/osmocom/pfcp/Makefile.am:
https://gerrit.osmocom.org/c/osmo-upf/+/27222/comment/570e053f_7d17c136
PS3, Line 17: pfcp_ies_auto.h: $(top_srcdir)/src/libosmo-pfcp/gen__pfcp_ies_auto.c \
Don't you need to depend on
$(top_builddir)/src/libosmo-tlv and $(top_builddir)/src/libosmo-pfcp bei […]
see the
"$(MAKE) -C ..." below.
If you know a better way to express cross-directory deps in automake do let me know.
That's the major weak point of automake, i wonder why no-one ever solved that
properly.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-upf/+/27222
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I3069045b2d42dac88d955c636230adc64a7a4aa7
Gerrit-Change-Number: 27222
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 17 Mar 2022 18:20:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment