Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593?usp=email ) Change subject: sgsn: Introduce test TC_attach_pdp_act_user ...................................................................... Patch Set 2: (4 comments) File sgsn/BSSGP_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593/comment/ccebc042_04cd… PS2, Line 614: Iu only Service Request is always Iu only, I see no need to add it everytime in the name, since it's usually going with [is_iu(ran_index)] clauses. I'm just adding it here as a comment for readers looking at this exact point. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593/comment/0da882be_b2e1… PS2, Line 635: f_service_request Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593/comment/8795391d_25aa… PS2, Line 651: [is_gb(ran_index)] Ack, this can be dropped, I'll do so. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593/comment/a0f43883_2dac… PS2, Line 806: completing the PDP ACT Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5f0cb51457395d95bde22732b032786211cb7b61 Gerrit-Change-Number: 37593 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 Jul 2024 09:08:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment