Attention is currently required from: pespin.
lynxis lazus has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hlr/+/32511 )
Change subject: hlr: use talloc for memory allocation in
osmo_gsup_create_insert_subscriber_data_msg
......................................................................
Patch Set 3:
(1 comment)
File src/gsup_server.c:
https://gerrit.osmocom.org/c/osmo-hlr/+/32511/comment/028179cd_f9bf0762
PS3, Line 455: void *talloc_ctx)
why not using the "struct osmo_gsup_message
*gsup" as a talloc_ctx?
because it's not guaranteed that gsup is a talloc
allocated buffed.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hlr/+/32511
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I00b5c2dfadcf6e0740e93b4c3292d2654d22e80c
Gerrit-Change-Number: 32511
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 26 Apr 2023 19:13:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment