Attention is currently required from: fixeria, pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36299?usp=email ) Change subject: docs: various osmux API documentation updates ...................................................................... Patch Set 4: (2 comments) File src/osmux.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15240): https://gerrit.osmocom.org/c/libosmo-netif/+/36299/comment/0f7310e1_31e75eb2 PS4, Line 30: #define SNPRINTF_BUFFER_SIZE(ret, remain, offset) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15240): https://gerrit.osmocom.org/c/libosmo-netif/+/36299/comment/52357ae3_7bbb3e8a PS4, Line 30: #define SNPRINTF_BUFFER_SIZE(ret, remain, offset) \ macros should not use a trailing semicolon -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36299?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5af0133322ddd5345a13380f1c007474c0bea117 Gerrit-Change-Number: 36299 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 19 Mar 2024 13:21:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment