Attention is currently required from: pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28609 )
Change subject: bsc: cbsp: Expect one Reset/Failure Ind for each Bcast Msg Type
......................................................................
Patch Set 1:
(1 comment)
File bsc/BSC_Tests_CBSP.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28609/comment/877e2cab_2d97…
PS1, Line 570: [not received_cbs] CBSP[0].receive(tr_CBSP_Recv(g_cbsp_conn_id[0],
rx_cbs)) {
this kind of construct looks like a prime use case for 'interleave' instead of
'alt. That way you don't need those received_{cbs,emerg} variables and the
related checks. The "received unexpected CBSP" could then become an altstep
that you acttivate before the interleave statement.
Not super-critical, just wanted to clarify that there is a TTCN3-native mechanism for
"wait for each of those things to happen [once], in any order".
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28609
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I05da2f61d26a1124d30793184d81aabf212cddda
Gerrit-Change-Number: 28609
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 15 Jul 2022 13:36:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment