Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29540 )

Change subject: stream: Set proper msgb length when returning sctp_notification ......................................................................

Patch Set 1:

(2 comments)

Patchset:

PS1:

IMHO we should directly set the msgb length in all cases where sctp_recvmsg() returned a length. […]

It's not returning user data, it's a really specific SCTP use case which we try to emulate through a generic API used by several protocols. I'm fine with submitting a new patch documenting it.

File src/stream.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/29540/comment/d45cb613_b3fc71e2 PS1, Line 1563: msgb_put(msg, ret);

i'd move this step to directly after sctp_recvmsg()

This is the generic and regular place where user data content is updated in the msgb, so it's fine here.