Change in libosmocore[master]: gsm0808: add logging for some IE encoding errors - gerrit-log

3 Jan 2023


      Attention is currently required from: neels, fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30581 )
Change subject: gsm0808: add logging for some IE encoding errors
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: 
another nit-pick: The log messages end up in GLOBAL and don't carry any information from which protocol/layer they related. Maybe the messages should include a 08.08 or BSSMAP or 48.008 string to give more context?  And maybe at that point it makes sense to have a specific log macro like LOGP0808() ?
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30581
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idd9c490e7a2d37817004590629092c4bb6f2d758
Gerrit-Change-Number: 30581
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: msuraev msuraev@sysmocom.de
Gerrit-CC: neels nhofmeyr@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Tue, 03 Jan 2023 13:14:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment