Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712 ) Change subject: Add subscr_conn_fsm ...................................................................... Patch Set 2: (7 comments) File include/osmocom/bsc_nat/bssap.h: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/5047569b_1fc69639 PS2, Line 30: struct bssmap_assignment_rqst { bssmap_ass_req? https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/c0bbc8b4_e144d436 PS2, Line 47: struct bssmap_assignment_complete { bssmap_ass_compl? File src/osmo-bsc-nat/bssap_conn.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/ad3adc36_38c006bc PS2, Line 69: static int bssmap_cn_handle_assignment_rqst(struct subscr_conn *subscr_conn, struct msgb *msg, unsigned int length) bssmap_cn_handle_ass_req? File src/osmo-bsc-nat/subscr_conn.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/3a765d31_3fa73ade PS2, Line 32: int subscr_conn_get_next_id(enum subscr_conn_id_type id_type) I'd rather split in 3 functions, using a macro if necessary. File src/osmo-bsc-nat/subscr_conn_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/6e0c97d9_7b9e4516 PS2, Line 72: case SUBSCR_CONN_FSM_EV_BSSMAP_CLEAR_COMMAND: missing break. Probably not affecting in behavior but I don't see an intended fall-through here. https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/4fbdceaa_2b622c3c PS2, Line 172: static int tx_assignment_request_to_ran(const struct subscr_conn *subscr_conn) If possible please move helper functions to the top, and put all the state FM functions together. https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/83e7cf62_47067cbd PS2, Line 351: , nice style to lose one an extra line for no good reason :D (j/k) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I7e491aada6f5db0eb35ef2039869c6ba07f9ca3b Gerrit-Change-Number: 27712 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 08 Apr 2022 17:10:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment