Attention is currently required from: pespin.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32552 )

Change subject: osmo-bts-trx: fix trx_ctrl_read_cb(): do not send CMDs twice ......................................................................

Patch Set 1:

(3 comments)

File src/osmo-bts-trx/trx_if.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/34988df9_f0880039 PS1, Line 732: /* Calling trx_ctrl_rx_rsp() may trigger code patch(s) queueing more CMDs.

typo: path

Done

https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/ed7e9dad_e2653ea5 PS1, Line 736: more_cmds = !llist_empty(&l1h->trx_ctrl_list);

It would be much more clearing storing this in a var called list_was_empty = llist_empty()

Ack

https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/f71beec7_b236ada6 PS1, Line 751: if (more_cmds)

Nevermind this comment.

This would not solve the problem of sending the same CMD twice.