Attention is currently required from: laforge, fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28328 )

Change subject: lchan_select: implement dynamic selection mode for assignment ......................................................................

Patch Set 5:

(3 comments)

File src/osmo-bsc/abis_rsl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/28328/comment/916edc0c_874940a3 PS5, Line 2010: if (lchan_avail_by_type(rqd->bts, GSM_LCHAN_TCH_F, SELECT_FOR_MS_CHAN_REQ, NULL, true)) { why pass NULL as ctx, isn't there any other talloc context available to hang this on that makes more sense? (same below a lot of times)

File src/osmo-bsc/lchan_select.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/28328/comment/382e7745_128d00e4 PS2, Line 231: qsort(&trx_list[0], bts->num_trx, sizeof(trx), &qsort_func);

I can find arguments in favor of both ways, I don't see a clear advantage of either over the other. […]

I guess it could be refactored to pass qsort_func to populate_ts_list, instead of passing sort_by_trx_power. But I don't have a strong opinion here, I'd be fine with merging this part as-is.

File src/osmo-bsc/lchan_select.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/28328/comment/8a3ed6c5_ed1a8d27 PS5, Line 271: } while (0) why add this instead of using a separate log category where one could enable/disable logging with the usual vty commands?