Attention is currently required from: jolly, pespin.

fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440?usp=email )

Change subject: 5gc: Implement NAS integrity check of DL messages ......................................................................

Patch Set 6: Code-Review+1

(5 comments)

File 5gc/C5G_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440/comment/ba61c8f9_ce646... : PS6, Line 44: NG_NAS_Osmo_Templates duplicate, check above

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440/comment/1356be67_51639... : PS6, Line 91: "192.168.123.50" idea: can probably be calculated from `imsi_suffix`?

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440/comment/d436fac7_845d9... : PS6, Line 310: abba I hear "ABBA - Dancing Queen" in my head when reading this :D

https://www.youtube.com/watch?v=xFrGuyw1V8s

File library/NG_CryptoFunctions.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440/comment/b07c64d1_f4a70... : PS6, Line 175: if (nus.role == NG_NAS_ROLE_UE) { : return true; : } else { : return false; : } `return nus.role == NG_NAS_ROLE_UE`?

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440/comment/4de3e160_8185c... : PS6, Line 264: make compiler happy about not returning does `mtc.stop` really make compiler happy? `f_shutdown()` does this internally...