Attention is currently required from: jolly, pespin.

Patch set 6:Code-Review +1

View Change

5 comments:

• File 5gc/C5G_Tests.ttcn:

  • Patch Set #6, Line 44: NG_NAS_Osmo_Templates

    duplicate, check above

  • Patch Set #6, Line 91: "192.168.123.50"

    idea: can probably be calculated from `imsi_suffix`?

  • Patch Set #6, Line 310: abba

    I hear "ABBA - Dancing Queen" in my head when reading this :D

    https://www.youtube.com/watch?v=xFrGuyw1V8s

• File library/NG_CryptoFunctions.ttcn:

  • Patch Set #6, Line 175:

    	if (nus.role == NG_NAS_ROLE_UE) {
    		return true;
    	} else {
    		return false;
    	}
    

    `return nus.role == NG_NAS_ROLE_UE`?

  • Patch Set #6, Line 264: make compiler happy about not returning

    does `mtc.stop` really make compiler happy?
    `f_shutdown()` does this internally...

To view, visit change 40440. To unsubscribe, or for help writing mail filters, visit settings.