Attention is currently required from: fixeria, laforge.
neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39741?usp=email )
Change subject: [1/6] personalization: refactor: drop ClassVarMeta use ......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS6:
CSV matching: I have other use cases than you do. […]
In this new patch set, the name and camel_to_snake() are back (they were lost by accident from branch rebasing).
reasons in my decision against a meta class: - i don't understand what purpose a meta class serves. - fixeria's example shows that the shortest way to achieve class attributes is ~~~ class Foo: a = 1 b = 2 ~~~ I like this plain python better than kwargs juggling. - upcoming patches add a lot of class attributes, and i would like to consistently use one way. I chose the "normal python" way, so as a first step, this patch drops the meta class.
- name: i would like to set explicit names like 'IMSI' instead of 'imsi', Hence i change to using an explicit 'name' attribute instead of getattr magic. When no explicit name is set, all still behaves as before this patch.
I hope that I've made my point, so i am now, in a hopeful way, resolving this thread. Please -1 again if i should change it.