Attention is currently required from: jolly, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31108 )
Change subject: layer23: Support configuring GSMTAP through VTY in l23 apps. ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/c88183a4_f02fdff1 PS2, Line 13: gsmtap
But there is no dedicated 'gsmtap' node in other apps, so it already does not match. […]
I'm not mixing them here, I'm establishing 2 layers of granularity. First based on lchan, and then further specify in the lchan which kind of messages we want (this is important in gprs because there may be lots of DUMMY messages).
https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/86c174e5_70ce782d PS2, Line 26: gsmtap-category
I don't like the inconsistency between 'gsmtap-sapi' and 'gsmtap-category'. My proposal: […]
I'm not really liking this proposal, it differs too much from separations done in other apps.