Attention is currently required from: osmith.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31622 )

Change subject: requires_voice_stream -> ch_indctr ......................................................................

Patch Set 1:

(2 comments)

Patchset:

PS1: You could even move this function to libosmocore.

File include/osmocom/bsc/gsm_08_08.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/31622/comment/8f1c90b3_15082d52 PS1, Line 16: bool bsc_requires_rtp_stream(enum gsm0808_chan_indicator ch_indctr); this function name sounds weird. Name seems to indicate it's some sort of global config, but you are actually simply checking stuff on chan_ind.

chan_ind_requires_rtp_stream sounds more accurate?