[M] Change in osmo-ggsn[master]: ggsn: use libosmocore tundev API to create apn tun device - gerrit-log

22 Oct 2024

Attention is currently required from: pespin.

osmith has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-ggsn/+/38480?usp=email )

Change subject: ggsn: use libosmocore tundev API to create apn tun device
......................................................................

Patch Set 3: Code-Review+1

(1 comment)

File lib/tun.c:

https://gerrit.osmocom.org/c/osmo-ggsn/+/38480/comment/519aa647_85838289?us… :
PS3, Line 201: err_free_tundev:
...
  Yes, I was thinking about that too, but I preferred to
keep it this way in this commit to make the c […] Acknowledged

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38480?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I4d99ba147ac0f3b414d2efef0068b6b8d6cf0014
Gerrit-Change-Number: 38480
Gerrit-PatchSet: 3
Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Reviewer: osmith &lt;osmith(a)sysmocom.de&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Comment-Date: Tue, 22 Oct 2024 09:21:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith &lt;osmith(a)sysmocom.de&gt;
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;