Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36140?usp=email ) Change subject: [RFC] ePDGId: allow passing both string and int type values ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: I think it's not worth the massive extra effort, both in modifying the code as well as generating test cases for it. Our promise is that whatever we generate during decode can be re-encoded. It's big enough a challenge to support that. Adding multiple different input formats just makes things a hell more complex, particularly as you can not simpyl do a decode -> reencode test, as the decode would always give you the string values -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36140?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I231fad78f5c5b5c23f38a6c913df957cfa06259e Gerrit-Change-Number: 36140 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 02 Mar 2024 09:15:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment