Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36037?usp=email )
Change subject: input/ipaccess: Always log with context, if we have any ......................................................................
Patch Set 1:
(3 comments)
File src/input/ipaccess.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14549): https://gerrit.osmocom.org/c/libosmo-abis/+/36037/comment/3325de40_0ebc380f PS1, Line 600: LOGPIL(line, DLINP, LOGL_NOTICE, "Keepalive is set: %i\n", ret); Use %d instead of %i
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14549): https://gerrit.osmocom.org/c/libosmo-abis/+/36037/comment/48b6c74f_113543b1 PS1, Line 979: " port=%u msg_type=%u\n", link->port, msg_type); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14549): https://gerrit.osmocom.org/c/libosmo-abis/+/36037/comment/bae5aeff_140570d9 PS1, Line 1072: "OML connecting to %s:%u\n", line->ops->cfg.ipa.addr, IPA_TCP_PORT_OML); code indent should use tabs where possible