Change in osmo-bsc[master]: gsm48_make_ho_cmd(): optionally add Cipher Mode Setting IE - gerrit-log

14 Mar 2022

Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/27507 )

Change subject: gsm48_make_ho_cmd(): optionally add Cipher Mode Setting IE
......................................................................

Patch Set 1:

(2 comments)

File src/osmo-bsc/gsm_04_08_rr.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/27507/comment/e0dddade_7544a434 
PS1, Line 584: 		if (new_lchan->encr.alg_id > ALG_A5_NR_TO_RSL(0))
...
  Looks like we want this stuff as
"lchan_get_cms()" put somewhere and reuse here and gsm48_send_rr_ci […]
This calculation is performed only two times, and both in this file. I hope after my
https://gerrit.osmocom.org/c/osmo-bsc/+/27509 is merged, the formula gets cleaner and
easier to read.

https://gerrit.osmocom.org/c/osmo-bsc/+/27507/comment/dd91f366_c86d545d 
PS1, Line 585: (new_lchan->encr.alg_id - 2) << 1 
Hi Neels,

...
  If I were to write this from scratch, I'd have
rather stored the plain A5/n number in encr.alg_id (as encr.alg_a5). Since we have alg_id
around everywhere already, I think it would be nice to have a macro like
ALG_A5_NR_TO_RSL() or a seprate function to explicitly show the intended conversion.

This is exactly why I submitted:

https://gerrit.osmocom.org/c/osmo-bsc/+/27509

because it's so confusing that we store it in the RSL specific format, and then print
it as-is in some logging statements without any conversion...

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27507
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1d270e82d0a9b12897fc94dae4e8999aa132a22f
Gerrit-Change-Number: 27507
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Reviewer: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Comment-Date: Mon, 14 Mar 2022 11:04:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-MessageType: comment