Attention is currently required from: dexter, fixeria, osmith.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/36930?usp=email )
Change subject: CardKeyProvider: Implement support for column-based transport key
encryption
......................................................................
Patch Set 6:
(2 comments)
File contrib/csv-encrypt-columns.py:
https://gerrit.osmocom.org/c/pysim/+/36930/comment/8e59ad46_be071c64
PS4, Line 38: #print("Encrypting col %s (val=%s)" % (colname, value))
(commented out code, do you want to keep this?)
Done
File docs/card-key-provider.rst:
https://gerrit.osmocom.org/c/pysim/+/36930/comment/1dca0c5a_5a30dda6
PS4, Line 70: * `SCP03_ISDR` for example is a group alias for `SCP03_ENC_ISDR`,
`SCP03_MAC_ISDR`, `SCP03_DEK_ISDR`
How about having the complete list here? I think that
would be slightly more userfriendly
Done
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/36930?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I13146a799448d03c681dc868aaa31eb78b7821ff
Gerrit-Change-Number: 36930
Gerrit-PatchSet: 6
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 04 Jun 2024 21:19:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment